Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncConnector: replace urllib.parse.urljoin with posixpath.join #139

Merged
merged 3 commits into from
Oct 30, 2024
Merged

AsyncConnector: replace urllib.parse.urljoin with posixpath.join #139

merged 3 commits into from
Oct 30, 2024

Conversation

squioc
Copy link
Collaborator

@squioc squioc commented Oct 2, 2024

No description provided.

@squioc squioc added the bug Something isn't working label Oct 2, 2024
@squioc squioc requested review from Darkheir, StephKll3c and a team October 2, 2024 09:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 2, 2024 •
edited
Loading

Test Results

215 tests  +3   214 ✅ +3   1m 42s ⏱️ -1s
  1 suites ±0     1 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 2d8dc1b. ± Comparison against base commit 29cd2b8.

♻️ This comment has been updated with latest results.

Darkheir
Darkheir previously approved these changes Oct 2, 2024
View reviewed changes
@squioc squioc force-pushed the fix/AsyncConnectorURLJoin branch from 8f8eb40 to 2d8dc1b Compare October 30, 2024 11:13
@squioc squioc requested a review from Darkheir October 30, 2024 11:13
@codecov Codecov
Copy link

codecov bot commented Oct 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.62%. Comparing base (29cd2b8) to head (2d8dc1b).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
sekoia_automation/aio/connector.py 83.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   90.64%   90.62%   -0.03%     
==========================================
  Files          34       34              
  Lines        2448     2453       +5     
==========================================
+ Hits         2219     2223       +4     
- Misses        229      230       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@squioc squioc merged commit b710358 into main Oct 30, 2024
8 of 9 checks passed
@squioc squioc deleted the fix/AsyncConnectorURLJoin branch October 30, 2024 14:21
@squioc squioc mentioned this pull request Oct 30, 2024
Merged
This was referenced Nov 28, 2024
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darkheir Darkheir Darkheir approved these changes

@StephKll3c StephKll3c Awaiting requested review from StephKll3c

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@squioc @Darkheir